Skip to content

Implemented CRUD_EVENT_NO_CHANGED_FIELDS_SKIP #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implemented CRUD_EVENT_NO_CHANGED_FIELDS_SKIP #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b06e48
Implemented CRUD_EVENT_NO_CHANGED_FIELDS_SKIP
felixcheruiyot Mar 14, 2023
9a37b37
Merge pull request #1 from felixcheruiyot/felixcheruiyot-patch-skip-n…
felixcheruiyot Mar 14, 2023
6190643
Fix crud exception issues and prevent propagation of exceptions
felixcheruiyot Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions easyaudit/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,22 @@
class ModelBackend:

def request(self, request_info):
return RequestEvent.objects.create(**request_info)
try:
return RequestEvent.objects.create(**request_info)
except Exception as e:
logger.error(f"Error creating RequestEvent: {e}")
return None

def crud(self, crud_info):
return CRUDEvent.objects.create(**crud_info)
try:
return CRUDEvent.objects.create(**crud_info)
except Exception as e:
logger.error(f"Error creating CRUDEvent: {e}")
return None

def login(self, login_info):
return LoginEvent.objects.create(**login_info)
try:
return LoginEvent.objects.create(**login_info)
except Exception as e:
logger.error(f"Error creating LoginEvent: {e}")
return None
43 changes: 27 additions & 16 deletions easyaudit/signals/model_signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import json
import logging

from django.db.utils import OperationalError
from django.conf import settings
from django.contrib.auth import get_user_model
from django.contrib.auth.models import AnonymousUser
Expand All @@ -18,7 +19,7 @@
from easyaudit.models import CRUDEvent
from easyaudit.settings import REGISTERED_CLASSES, UNREGISTERED_CLASSES, \
WATCH_MODEL_EVENTS, CRUD_DIFFERENCE_CALLBACKS, LOGGING_BACKEND, \
DATABASE_ALIAS
DATABASE_ALIAS, CRUD_EVENT_NO_CHANGED_FIELDS_SKIP
from easyaudit.utils import get_m2m_field_name, model_delta

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -73,6 +74,9 @@ def pre_save(sender, instance, raw, using, update_fields, **kwargs):
try:
if not should_audit(instance):
return False

if CRUD_EVENT_NO_CHANGED_FIELDS_SKIP:
return

with transaction.atomic(using=using):
try:
Expand Down Expand Up @@ -122,17 +126,17 @@ def crud_flow():
})
except Exception as e:
try:
logger.exception(
logger.error(
"easy audit had a pre_save exception on CRUDEvent creation. instance: {}, instance pk: {}".format(
instance, instance.pk))
instance, instance.pk), exc_info=True)
except Exception:
pass
if getattr(settings, "TEST", False):
crud_flow()
else:
transaction.on_commit(crud_flow, using=using)
except Exception:
logger.exception('easy audit had a pre-save exception.')
logger.error('easy audit had a pre-save exception.', exc_info=True)


def post_save(sender, instance, created, raw, using, update_fields, **kwargs):
Expand Down Expand Up @@ -181,17 +185,20 @@ def crud_flow():
})
except Exception as e:
try:
logger.exception(
logger.error(
"easy audit had a post_save exception on CRUDEvent creation. instance: {}, instance pk: {}".format(
instance, instance.pk))
instance, instance.pk), exc_info=True)
except Exception:
pass
if getattr(settings, "TEST", False):
crud_flow()
else:
transaction.on_commit(crud_flow, using=using)
except Exception:
logger.exception('easy audit had a post-save exception.')

except OperationalError as ex:
logger.error(f'Easy audit had a post-save OperationalError. {ex}', exc_info=True)
except Exception as ex:
logger.error(f'Easy audit had a post-save exception. {ex}', exc_info=True)


def _m2m_rev_field_name(model1, model2):
Expand Down Expand Up @@ -279,18 +286,20 @@ def crud_flow():
})
except Exception as e:
try:
logger.exception(
logger.error(
"easy audit had a m2m_changed exception on CRUDEvent creation. instance: {}, instance pk: {}".format(
instance, instance.pk))
instance, instance.pk), exc_info=True)
except Exception:
pass

if getattr(settings, "TEST", False):
crud_flow()
else:
transaction.on_commit(crud_flow, using=using)
except Exception:
logger.exception('easy audit had an m2m-changed exception.')
except OperationalError as ex:
logger.error(f'Easy audit had a m2m-changed OperationalError. {ex}', exc_info=True)
except Exception as ex:
logger.error(f'Easy audit had a m2m-changed exception. {ex}', exc_info=True)


def post_delete(sender, instance, using, **kwargs):
Expand Down Expand Up @@ -327,18 +336,20 @@ def crud_flow():

except Exception as e:
try:
logger.exception(
logger.error(
"easy audit had a post_delete exception on CRUDEvent creation. instance: {}, instance pk: {}".format(
instance, instance.pk))
instance, instance.pk), exc_info=True)
except Exception:
pass

if getattr(settings, "TEST", False):
crud_flow()
else:
transaction.on_commit(crud_flow, using=using)
except Exception:
logger.exception('easy audit had a post-delete exception.')
except OperationalError as ex:
logger.error(f'Easy audit had a post-delete OperationalError. {ex}', exc_info=True)
except Exception as ex:
logger.error(f'Easy audit had a post-delete exception. {ex}', exc_info=True)


if WATCH_MODEL_EVENTS:
Expand Down