Change of proof location in an event #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffrr
requested changes
Aug 20, 2025
|
|
||
| const proof = this.veritas.verifyProof(evt.proof); | ||
|
|
||
| const proofBase64 = getProofFromTags(evt.tags); |
There was a problem hiding this comment.
Encoding the proof as a base64 string significantly increases the size of each event sent over the wire which undermines the purpose of CompactEvent being compact. We should keep the proof in binary form when transmitting, especially to avoid UDP fragmentation issues.
| if (isNaN(evt.kind)) throw new Error('Invalid event kind must be a number'); | ||
|
|
||
| let space, d; | ||
|
|
||
| for (const tag of evt.tags) { | ||
| if (tag.length < 2) continue; | ||
| if (!space && anchored && tag[0] === 'space') { | ||
| if (!space && anchored && tag[0] === 's' && tag.length >= 2) { |
There was a problem hiding this comment.
isn't the tag.length >= 2 redundant given there's if (tag.length < 2) continue; first?
|
Another concern is that this change isn’t backward compatible with existing Fabric nodes. Not many deployed yet but it’s still something we should take into account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it seeks a proof in the tags as described here: