Update: Port for Sphinx 8.x.x, fix path naming and Cargo.toml compatibility #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested both with sphinx 7.4.7 and sphinx 8.1.3. Signed-off-by: Nicolae Dicu <[email protected]>
Allows integration via pip. Signed-off-by: Nicolae Dicu <[email protected]>
Resolved to folders instead of creating link with "::". Resolves: eclipse-score/score#1487 and eclipse-score/score#1488 Signed-off-by: Nicolae Dicu <[email protected]>
The module used old implementation of Cargo.toml parsing. Resolves: eclipse-score/score#1522 Signed-off-by: Nicolae Dicu <[email protected]>
|
Cheers! will have a look soon |
chrisjsewell
requested changes
Aug 7, 2025
There was a problem hiding this comment.
I haven't fully looked through the PR just yet, but if you could firstly fix the pre-commit issues that would be great thanks (see https://github.com/sphinx-extensions2/sphinx-rust/blob/main/CONTRIBUTING.md)
chrisjsewell
reviewed
Aug 7, 2025
fix: error: package `cargo-platform v0.1.9` cannot be built because it requires rustc 1.78 or newer, while the currently active rustc version is 1.75.0
Signed-off-by: Nicolae Dicu <[email protected]>
|
@nicu1989 can you check for the failing CI? |
Sphinx 8.0 dropped python 3.9 support. Signed-off-by: Nicolae Dicu <[email protected]>
|
@ubmarco I have fixed the CI. Dropped support for python 3.9 according to sphinx 8.0 docs: https://www.sphinx-doc.org/en/master/changes/8.0.html Can a maintainer trigger the check CI please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/fixes:
Works with Sphinx 8.x+ (latest)
Fixes working with modern Cargo project layouts (support workspace versioning and TOML)
Bug: Sphinx_rust cannot properly parse Cargo.toml eclipse-score/score#1522
Fixes docutils Path/StrPath objects
Bug: Incremental bazel build filename eclipse-score/score#1487
Bug: Re-building with incremental is broken due to filenaming eclipse-score/score#1488