Skip to content

Add with_page_index when using limit push down #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Add with_page_index when using limit push down #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/iceberg/src/arrow/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ impl ArrowReader {
row_group_filtering_enabled: bool,
row_selection_enabled: bool,
) -> Result<ArrowRecordBatchStream> {
let should_load_page_index =
(row_selection_enabled && task.predicate.is_some()) || !task.deletes.is_empty();
let should_load_page_index = (row_selection_enabled && task.predicate.is_some())
|| !task.deletes.is_empty()
|| task.limit.is_some();

// concurrently retrieve delete files and create RecordBatchStreamBuilder
let (_, mut record_batch_stream_builder) = try_join!(
Expand Down Expand Up @@ -341,7 +342,7 @@ impl ArrowReader {
// Create the record batch stream builder, which wraps the parquet file reader
let record_batch_stream_builder = ParquetRecordBatchStreamBuilder::new_with_options(
parquet_file_reader,
ArrowReaderOptions::new(),
ArrowReaderOptions::new().with_page_index(should_load_page_index),
)
.await?;
Ok(record_batch_stream_builder)
Expand Down