-
Notifications
You must be signed in to change notification settings - Fork 411
Add detection Windows Modify Registry for IE Proxy Setting #3607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Please use the --verbose command line argument if you need more context for your error or file a bug report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions regarding the rule and the format.
Processes.process_path="*\\cmd.exe" | ||
) | ||
by _time, Processes.dest, Processes.user | ||
| rex field=Command_Line "reg\\s+add\\s+\\\"(?<registry_path>[^\"]+)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex would only work when using reg.exe add
. This would not cover the PowerShell case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this comment, i already change it. actually i change from tstats to index first to make sure it work. my lab is not yet setting datamodel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to ship as tstats and CIM for better compatibility. As this is one of the most used and normalized data sources.
detections/endpoint/windows_modify_registry_for_ie_proxy_settings.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/windows_modify_registry_for_ie_proxy_settings.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/windows_modify_registry_for_ie_proxy_settings.yml
Outdated
Show resolved
Hide resolved
detections/endpoint/windows_modify_registry_for_ie_proxy_settings.yml
Outdated
Show resolved
Hide resolved
The Appinspect job is expected to fail for contributions from forks. |
NOT ( | ||
Details="DWORD*" | ||
OR Details IN ("Cookie:", "Visited:", "(Empty)") | ||
OR match(Process_Command_Line, ".*\\\\Cache.*|.*\\\\ZoneMap.*|.*\\\\WpadDecision.*") | ||
OR Details="Binary Data" | ||
OR Process_Command_Line="*\\Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings\\Accepted Documents*" | ||
OR New_Process_Name="C:\\Windows\\System32\\RuntimeBroker.exe" | ||
) | ||
| rex field=Process_Command_Line "(?i)(new-itemproperty|set-itemproperty|set-item|reg\\s+add|new-item)[^\n\r]*?(?<registry_path>HK(?:EY_)?(?:LM|CU|CR|U)[:\\\\][^\"'\s]+(?:\\\\[^\"'\s]*)*)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The details field is not part of a 4688 event
Also after thinking about it, the regex is overkill.
While it is nice to have that extraction for better display. I do not think it will add a lot of value. Since the commandline have to be inspected regardless.
Details
Checklist
<platform>_<mitre att&ck technique>_<short description>
nomenclatureNotes For Submitters and Reviewers
build
CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.