[TEST] Bartek's Lab #629
Draft
[TEST] Bartek's Lab #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecyliaborek
reviewed
Aug 1, 2025
|
|
||
| - name: Test Execution | ||
| - name: Install dependencies | ||
| run: pip install . |
There was a problem hiding this comment.
this will install all dependencies defined in pyproject which I think is an overkill if we only need tox
| version = "2.1.0" | ||
| description = "The Splunk Software Development Kit for Python" | ||
| readme = "README.md" | ||
| requires-python = ">=3.9, <4" |
| "streetsidesoftware.code-spell-checker", | ||
| "pflannery.vscode-versionlens", | ||
| "splunk.splunk", | ||
| "charliermarsh.ruff" |
There was a problem hiding this comment.
shouldn't for example ruff be added as dependency in pyproject
Comment on lines
+17
to
+22
| # Assure backport for Python <3.9 | ||
| try: | ||
| from importlib.metadata import version as importlib_metadata_version | ||
| except (ImportError, ModuleNotFoundError): | ||
| from importlib_metadata import version as importlib_metadata_version | ||
|
|
There was a problem hiding this comment.
this fails the tests/searchcommands/test_csc_apps.py - apps don't have access to metadata of SDK in current test setup
| @@ -0,0 +1 @@ | |||
| 3.9.23 | |||
There was a problem hiding this comment.
I am wondering which python should be our default since we are developing for several python versions and sometimes you need to switch between them? Or no?
mateusz834
reviewed
Aug 1, 2025
| make wait_up | ||
| make test | ||
| make down | ||
| ``` |
There was a problem hiding this comment.
Mention cp .env.template .env? Otherwise tests will fail with an AuthenticationError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just me trying to break and fix stuff