Skip to content

Conversation

moh-hassan
Copy link

@moh-hassan moh-hassan commented Dec 14, 2021

Fix #184 NewLine in CommentParser for Linux/Windows Environment.
Also, the PR fix a fail of test case when running the test project in Linux (Ubuntu 18.04)

Sprache.Tests.Scenarios.AssemblerTests.CanParseSeceralLines [FAIL]
  Failed Sprache.Tests.Scenarios.AssemblerTests.CanParseSeceralLines [3 ms]
  Error Message:
   Assert.Equal() Failure

@nblumhardt
Copy link
Member

Hi! Thanks for this. Looks like the problem is actually in the constructor, line 36? (The newline style there is at odds with the comment). I think a permissive scheme of handling any new-line char would work best here though 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test for testing single comment generated by CommentParser class pass in linux and fail in windows

2 participants