Add Javadoc to ParametersTransformer #1239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
asalgado/2.5.x/javadoc-ParametersTransformer
branch
from
3975d36 to
f6e09b8
Compare
Signed-off-by: Abel Salgado Romero <[email protected]>
abelsromero
force-pushed
the
asalgado/2.5.x/javadoc-ParametersTransformer
branch
from
f6e09b8 to
566f435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given recent research, I'd like to document in the class what the expectation is for the returned value.
We could consider changing the logic so that the value is used; this will reduce reliance on mutation. However, the rest of the core relies on passing the same instance to other methods. So I don't feel confident that this is an easy change.