Skip to content

Fix incorrect usage of @AutoConfiguration #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect usage of @AutoConfiguration #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ain/java/org/springframework/cloud/client/loadbalancer/LoadBalancerAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
* @author Gang Li
* @author Olga Maciaszek-Sharma
* @author Henning Pöttker
* @author Yanming Zhou
*/
@AutoConfiguration
@Conditional(BlockingRestClassesPresentCondition.class)
Expand Down Expand Up @@ -83,7 +84,7 @@ public LoadBalancerRequestFactory loadBalancerRequestFactory(LoadBalancerClient
return new LoadBalancerRequestFactory(loadBalancerClient, transformers);
}

@AutoConfiguration
@Configuration(proxyBeanMethods = false)
static class DeferringLoadBalancerInterceptorConfig {

@Bean
Expand Down Expand Up @@ -122,7 +123,7 @@ LoadBalancerRestClientHttpServiceGroupConfigurer loadBalancerRestClientHttpServi

}

@AutoConfiguration
@Configuration(proxyBeanMethods = false)
@Conditional(RetryMissingOrDisabledCondition.class)
static class LoadBalancerInterceptorConfig {

Expand Down Expand Up @@ -165,7 +166,7 @@ static class RetryDisabled {
/**
* Auto configuration for retry mechanism.
*/
@AutoConfiguration
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(RetryTemplate.class)
public static class RetryAutoConfiguration {

Expand Down
Loading