Skip to content

Initial support for JSpecify #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

Initial support for JSpecify #1594

merged 1 commit into from
Oct 31, 2025

Conversation

@ryanjbaxter
Copy link
Contributor

@ryanjbaxter ryanjbaxter commented Oct 30, 2025

No description provided.

@ryanjbaxter ryanjbaxter added this to the 5.0.0-RC1 milestone Oct 30, 2025
spencergibb
spencergibb approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can remove the commented out dependencies

@ryanjbaxter ryanjbaxter force-pushed the nullability branch 2 times, most recently from 00134b9 to bd37c84 Compare October 31, 2025 00:13
@ryanjbaxter ryanjbaxter marked this pull request as ready for review October 31, 2025 14:39
@ryanjbaxter
Copy link
Contributor Author

ryanjbaxter commented Oct 31, 2025

@spencergibb I added some additional @Nullable annotations based on where we return null or check for null.

@spencergibb spencergibb moved this to In Progress in 2025.1.0-RC1 Oct 31, 2025
@ryanjbaxter ryanjbaxter merged commit f409a1c into main Oct 31, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2025.1.0-RC1 Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencergibb spencergibb spencergibb approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

2025.1.0-RC1
Status: Done

Milestone

5.0.0-RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanjbaxter @spencergibb