refactor: move Elasticsearch classes to dedicated package and use bui… #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Sets the batching strategy for vector operations. | ||
| * @param batchingStrategy the batching strategy to use | ||
| * @return the builder instance | ||
| * @throws IllegalArgumentException if batchingStrategy is null |
There was a problem hiding this comment.
Where do we throw IllegalArgumentException? Same question for other places we specify that the exception is thrown for invalid values.
There was a problem hiding this comment.
In the method implementation, the Assert.notNull(..) call would throw the IAE.
sobychacko
force-pushed
the
es-vs-builder
branch
from
e4844e1 to
a6c5d6d
Compare
|
updated ref docs and class javadoc for ElasticSearchVectorStore. merged in fc1f92d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lder pattern