Add JsonIgnoreProperties to DeepSeek Model Response objects #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue of commit 53019c6 See spring-projectsGH-3026 Signed-off-by: Yanming Zhou <[email protected]>
Contributor
Author
|
@ilayaperumalg Hi, you forgot this one. |
Member
|
@quaff Thanks for the PR following it up! |
ilayaperumalg
approved these changes
May 9, 2025
| import com.fasterxml.jackson.annotation.JsonFormat; | ||
| import com.fasterxml.jackson.annotation.JsonIgnore; | ||
| import com.fasterxml.jackson.annotation.JsonInclude; | ||
| import com.fasterxml.jackson.annotation.*; |
Member
There was a problem hiding this comment.
wildcard imports aren't allowed - will fix when merging.
| * {@link ToolChoiceBuilder} to create the tool choice value. | ||
| */ | ||
| @JsonInclude(Include.NON_NULL) | ||
| @JsonIgnoreProperties(ignoreUnknown = true) |
Member
There was a problem hiding this comment.
We want to add this annotation only for the response objects. Hence, we can remove this. Will fix it when merging.
Member
|
Rebased and merged as 5b2f5ee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of commit 53019c6
See GH-3026