Skip to content

Conversation

ThomasVitale
Copy link
Contributor

  • Add missing fields to Ollama API classes
  • Deprecate Ollama options that are no longer supported
  • Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

* Add missing fields to Ollama API classes
* Deprecate Ollama options that are no longer supported
* Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

Signed-off-by: Thomas Vitale <[email protected]>
@sunyuhan1998
Copy link
Contributor

Thank you for your work, it looks great! Additionally, I noticed that you've added support for "think" in OllamaApi. I think if this PR is accepted, my previous PR #3386 will no longer be needed.

@dnwwdwd
Copy link

dnwwdwd commented Aug 4, 2025

hello.I want to ask if this change was applied in the latest 1.0.1 version, as it seems I didn't see this change.

@ThomasVitale
Copy link
Contributor Author

@sunyuhan1998 thanks for your comment. This PR only updates the Ollama API (including the new think field), but it doesn't expose it yet. I see your PR provides a way to use it from the OllamaChatModel, which I think it'd still be beneficial to have.

@dnwwdwd this PR has not been merged yet, so it's not included in the latest 1.0.1 version.

@sobychacko
Copy link
Contributor

@ThomasVitale Do you think we should back-port this PR into 1.0.x? Thanks.

@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@ThomasVitale
Copy link
Contributor Author

@sobychacko That would be nice to have already in 1.0.x, if it's possible. It would give us the possibility to remove the deprecated Ollama options in 1.1.x.

This PR is backward compatible as it only adds new fields in OllamaApi and deprecates options and fields that Ollama doesn't support anymore. Builders and custom constructors help ensuring the backward compatibility even if some records got new fields.

@sobychacko sobychacko closed this in 3ee33c1 Aug 6, 2025
spring-builds pushed a commit that referenced this pull request Aug 6, 2025
* Add missing fields to Ollama API classes
* Deprecate Ollama options that are no longer supported
* Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

Fixes #3969

Signed-off-by: Thomas Vitale <[email protected]>
(cherry picked from commit 3ee33c1)
@sobychacko
Copy link
Contributor

@ThomasVitale Merged upstream and backported to 1.0.x (#4037).

@ThomasVitale
Copy link
Contributor Author

@sobychacko thank you!

juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
* Add missing fields to Ollama API classes
* Deprecate Ollama options that are no longer supported
* Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

Fixes spring-projects#3969

Auto-cherry-pick to 1.0.x

Signed-off-by: Thomas Vitale <[email protected]>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
* Add missing fields to Ollama API classes
* Deprecate Ollama options that are no longer supported
* Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

Fixes spring-projects#3969

Auto-cherry-pick to 1.0.x

Signed-off-by: Thomas Vitale <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
* Add missing fields to Ollama API classes
* Deprecate Ollama options that are no longer supported
* Update integration tests using Ollama 0.10.1 (latest version) and more performant models.

Fixes spring-projects#3969

Auto-cherry-pick to 1.0.x

Signed-off-by: Thomas Vitale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants