New spring-batch-s3 module #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Cioni <[email protected]>
andreacioni
force-pushed
the
spring-batch-s3
branch
from
b6e9643 to
e3f3ce1
Compare
dgray16
reviewed
Jul 6, 2025
...tch-s3/src/main/java/org/springframework/batch/extensions/s3/stream/S3MultipartUploader.java
Show resolved
Hide resolved
spring-batch-s3/src/test/java/org/springframework/batch/extensions/s3/S3ItemReaderTests.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/springframework/batch/extensions/s3/stream/S3MultipartOutputStreamTests.java
Outdated
Show resolved
Hide resolved
...3/src/test/java/org/springframework/batch/extensions/s3/stream/S3MultipartUploaderTests.java
Outdated
Show resolved
Hide resolved
...tch-s3/src/test/java/org/springframework/batch/extensions/s3/stream/S3OutputStreamTests.java
Outdated
Show resolved
Hide resolved
scordio
reviewed
Jul 6, 2025
There was a problem hiding this comment.
Hi @andreacioni, thanks for the PR!
I suggest adding a CI job, see for example the one for Spring Batch Notion.
Also, the new module should be mentioned in the root README.
Signed-off-by: Andrea Cioni <[email protected]>
- Builders moved to a dedicated package - project README.adoc updated; - root README.md updated: add reference to new module; - use org.springframework.util.unit.DataSize to express data sizes; - removed apache-client exclusion in pom.xml to allow user to not specify an actual implementation in their dependencies - updated spring-javaformat-checkstyle to match the latest version - update gitignore to match the one of Spring Batch Notion - Add Maven Wrapper executables - Add Github Action workflow - Removed maven-wrapper.jar - Code cleanup Signed-off-by: Andrea Cioni <[email protected]>
dgray16
reviewed
Jul 8, 2025
dgray16
reviewed
Jul 8, 2025
- pom.xml reformatted - root README missing Amazon S3 link - atLeastOnce abandoned in favor of times(x) - minor corrections Signed-off-by: Andrea Cioni <[email protected]>
Signed-off-by: Andrea Cioni <[email protected]>
Signed-off-by: Andrea Cioni <[email protected]>
dgray16
approved these changes
Jul 10, 2025
...ch-s3/src/main/java/org/springframework/batch/extensions/s3/builder/S3ItemWriterBuilder.java
Outdated
Show resolved
Hide resolved
spring-batch-s3/src/main/java/org/springframework/batch/extensions/s3/stream/Defaults.java
Outdated
Show resolved
Hide resolved
spring-batch-s3/src/test/java/org/springframework/batch/extensions/s3/S3ItemReaderTests.java
Show resolved
Hide resolved
Co-authored-by: Volodymyr <[email protected]> Signed-off-by: Andrea Cioni <[email protected]>
…ions/s3/S3ItemReaderTests.java Co-authored-by: Volodymyr <[email protected]> Signed-off-by: Andrea Cioni <[email protected]>
…ions/s3/builder/S3ItemWriterBuilder.java Co-authored-by: Volodymyr <[email protected]> Signed-off-by: Andrea Cioni <[email protected]>
…ions/s3/stream/Defaults.java Co-authored-by: Volodymyr <[email protected]> Signed-off-by: Andrea Cioni <[email protected]>
scordio
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
after struggling a bit with S3 and Spring Batch I want to contribute to this ecosystem with my little knowledge by proposing this PR to your attention. In the past I've followed some discussion that lead me here (mainly #3818). I had to work with S3 in the past years and I had to implement such Reader/Writer each time, moreover it's a new addition to AWS SDK the API to upload objects with unknown size (reference) from streams. Given this inputs I decided that was time for Spring Batch to have some support for S3, hope this will be welcome.
More information are in the README, please let me know if there is something missing I'd be happy to fix it.