Ensure RestClient uses Virtual Thread Executor when spring.threads.virtual.enabled=true and JdkClientHttpRequestFactoryBuilder #46404
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
… thread support Signed-off-by: Sangmin Park <[email protected]>
…ation Signed-off-by: Sangmin Park <[email protected]>
philwebb
added
the
for: team-attention
|
Flagging for team attention to see if we consider this a bug or enhancement. I lean towards enhancement. |
|
While checking, I noticed that there is an existing related issue. I’ll attach it here so it can be referenced. |
philwebb
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even when setting
spring.threads.virtual.enabled=true,HttpClientinRestClientcontinued to create platform threads. This meant that enabling virtual threads via configuration did not actually switch the executor as users would expect.What has changed
ClientHttpRequestFactoryBuilderbean has been split based on the threading mode.Threading.VIRTUALis active and the builder is aJdkClientHttpRequestFactoryBuilder, the builder is explicitly configured to use a virtual thread executor.