Skip to content

Enhance CouchbaseDocument and CouchbaseList to handle List implementa… #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enhance CouchbaseDocument and CouchbaseList to handle List implementa… #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import java.util.TreeMap;
import java.util.Map;
import java.util.List;

/**
* A {@link CouchbaseDocument} is an abstract representation of a document stored inside Couchbase Server.
Expand Down Expand Up @@ -275,8 +276,14 @@ private void verifyValueType(final Object value) {
if (CouchbaseSimpleTypes.DOCUMENT_TYPES.isSimpleType(clazz)) {
return;
}

// Special handling for List implementations like Collections.SingletonList and ArrayList
if (value instanceof List) {
return;
}

throw new IllegalArgumentException(
"Attribute of type " + clazz.getCanonicalName() + " cannot be stored and must be converted.");
"Attribute of type " + clazz.getCanonicalName() + " cannot be stored in document and must be converted.");
}

/**
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,14 @@ private void verifyValueType(final Object value) {
if (simpleTypeHolder.isSimpleType(clazz)) {
return;
}

// Special handling for List implementations like Collections.SingletonList and ArrayList
if (value instanceof List) {
return;
}

throw new IllegalArgumentException(
"Attribute of type " + clazz.getCanonicalName() + " can not be stored and must be converted.");
"Attribute of type " + clazz.getCanonicalName() + " cannot be stored in list and must be converted.");
}

/**
Expand Down