Handle Kotlin nullable value class param correctly in CoroutineUtils#36449
Open
T45K wants to merge 1 commit intospring-projects:mainfrom
Open
Handle Kotlin nullable value class param correctly in CoroutineUtils#36449T45K wants to merge 1 commit intospring-projects:mainfrom
CoroutineUtils#36449T45K wants to merge 1 commit intospring-projects:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as-is: under some conditions, spring framework throws an exception when calling a suspend function that has nullable value class param with a non-null value class object arg
to-be: spring framework can handle it correctly
reproducer: https://github.com/T45K/Spring-CoroutineUtils-bug-reproducer
root cause:
when
CoroutineUtilsis called to invoke such suspend functions with a non-null value class object arg, it tries toboxthe arg even though the type of the arg is already boxed value class.that causes
IllegalArgumentException(when the param is non-null type, its arg will be expected unboxed type).
solution: removing
arg == nullcondition. it's unnecessary.discussion: there are similar code in
InvocableHandlerMethod. i'm not sure it should be fixed too