Update Spring grpc to 1.1.0-SNAPSHOT#381
Conversation
...lient/src/test/java/org/springframework/integration/samples/grpc/client/GrpcClientTests.java
Show resolved
Hide resolved
build.gradle
Outdated
| @@ -889,14 +889,12 @@ project('grpc-client') { | |||
| dependencies { | |||
| implementation platform("org.springframework.grpc:spring-grpc-dependencies:$springGrpc") | |||
There was a problem hiding this comment.
I think if we go with fully Spring Boot, then we don't need this to manage manually.
As well as just rely on the Spring gRPC version coming from there.
Therefore, we don't need that springGrpc variable at all.
BTW, pay attention it is not like others.
Should be springGrpcVersion.
Either way, I believe we don't need it at all.
build.gradle
Outdated
| implementation("com.google.protobuf:protobuf-java:$protobufVersion") | ||
|
|
||
| //Test | ||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' |
There was a problem hiding this comment.
We don't need this: comes transitively from the spring-boot-starter-grpc-test
- Removed redundant dependencies - Removed unused properties
build.gradle
Outdated
| slf4jVersion = '2.0.17' | ||
| springCloudVersion = '2025.1.0' | ||
| springGrpc = '1.0.2' | ||
| springGrpc = '1.1.0-SNAPSHOT' |
There was a problem hiding this comment.
So, do we still need this?
And why then it is not named as springGrpcVersion to align with the rest in this set?
| private static final Log LOGGER = LogFactory.getLog(GrpcClientConfiguration.class); | ||
|
|
||
| @Value("${spring.grpc.client.channels.spring-integration.address}") | ||
| private String grpcServerAddress; |
There was a problem hiding this comment.
The @Value can simply go to the method argument of the specific bean definition.
There is no need in the dedicated property on the matter.
- localized the server port `@value`
| @Bean | ||
| ManagedChannel managedChannel(GrpcChannelFactory factory) { | ||
| return factory.createChannel(this.grpcServerAddress); | ||
| ManagedChannel managedChannel(GrpcChannelFactory factory, @Value("${spring.grpc.client.channels" + |
There was a problem hiding this comment.
Why this grpcServerAddress argument definition cannot be from a new line altogether?
2 participants
No description provided.