Skip to content

Remove Netty dependency exclude from tests#383

Merged
artembilan merged 2 commits intospring-projects:mainfrom
cppwfs:SIS-remove-exclude
Mar 26, 2026
Merged

Remove Netty dependency exclude from tests#383
artembilan merged 2 commits intospring-projects:mainfrom
cppwfs:SIS-remove-exclude

Conversation

@cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Mar 26, 2026

To disable the activation of the Netty server when using the inprocess server add @AutoConfigureTestGrpcTransport to the test.

To disable the activation of the Netty server when using the
inprocess server  add `@AutoConfigureTestGrpcTransport` to the test.
@cppwfs cppwfs requested a review from artembilan March 26, 2026 10:42
},
target = "in-process:test"
)
@AutoConfigureTestGrpcTransport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I don’t know what this annotation is doing and I don’t say that there is something wrong in your solution, but I wonder if there is some overlap with this annotation and those explicit properties for `inprocess'. In general I have feeling that if I go this annotation, then I don’t need those properties: they should be inferred from this annotation . Perhaps some further idea how to improve Spring Boot experience

Copy link
Contributor Author

@cppwfs cppwfs Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was based on a recommendation from @philwebb. In short AutoConfigureTestGrpcTransport
enables auto-configuration of the GrpcServletRegistration, GrpcServerFactory, GrpcChannelFactory. When using this annotation the defaults for these autoconfigurations is false, thus in our case the servlet engine is not autoconfigured.

You are correct that we can now remove the explicit properties.

With the use of the `@AutoConfigureTestGrpcTransport` these are no
longer necessary
@artembilan artembilan merged commit 80e129a into spring-projects:main Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants