GH-10083: Apply Nullability to Core expression package
#10265
Merged
+220
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 * Make `SupplierExpression` as to not return null for result of the provided `Supplier`. And fix Nullability from the super contract * Make `ValueExpression` compatible with super contract, but still ensure not null for return value * Make `DynamicExpression` compatible with super contract. Provide usability and code style refactoring * Make `FunctionExpression` to be compatible with super contract. At the same time ensure that input for the function is not null, but result of function could be null. Some other code style and usability refactoring * Remove redundant logic in the `ExpressionUtils` which is deliberately not reachable due to Nullability * Fix Nullability for the `ReloadableResourceBundleExpressionSource` and some simple refactoring according to IDE report. * Make `ExpressionEvalMap` to be aware of null values after expressions evaluation. * Fix usage of the `ExpressionEvalMap` in the project. * Mark `CassandraMessageHandler.setQuery()` with `NullAway` since `ExpressionEvalMap` may produce nulls, and Cassandra driver can deal with nulls, but that is not expressed on the API with Nullability * Fix `ThreadStatePropagationChannelInterceptor` for wrong import for the `@Nullable` * Slight change in the `GraphQlMessageHandler` according to the mentioned above `expression` package fixes
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083
SupplierExpressionas to not return null for result of the providedSupplier. And fix Nullability from the super contractValueExpressioncompatible with super contract, but still ensure not null for return valueDynamicExpressioncompatible with super contract. Provide usability and code style refactoringFunctionExpressionto be compatible with super contract. At the same time ensure that input for the function is not null, but result of function could be null. Some other code style and usability refactoringExpressionUtilswhich is deliberately not reachable due to NullabilityReloadableResourceBundleExpressionSourceand some simple refactoring according to IDE report.ExpressionEvalMapto be aware of null values after expressions evaluation.ExpressionEvalMapin the project.CassandraMessageHandler.setQuery()withNullAwaysinceExpressionEvalMapmay produce nulls, and Cassandra driver can deal with nulls, but that is not expressed on the API with NullabilityThreadStatePropagationChannelInterceptorfor wrong import for the@NullableGraphQlMessageHandleraccording to the mentioned aboveexpressionpackage fixes