Make RedisLockRegistry work again for both Redis Cluster and AWS Elastic Valkey Cluster #10557
+27
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #10546.
In redis and redis cluster,
PUBLISHis not sharded. Thus, the first argument does not need to has hto the same cluster slot as all other keys in a lua script. However, on execution of a lua script, redis cluster still checks if all keys inKEYShash to the same shard.In #10473 I changed that the unlock channel kay was passed in
KEYSinstead ofARGV, as AWS Elastic Valkey Cluster uses sharded PubSub and thusSPUBLISHinternally and requires, that the first argument ofPUBLISHhashes to the same shared asKEYS[1].However, it can still be passed in
ARGV, which makes Redis Cluster work again, without the need for hash tags{...}in the given lock key to control the sharding explicitly.