added a feature for the user to input testing URL #7
Conversation
|
Hello @spyboy-productions, can you take a look at this PR. |
Hi, thanks for the PR. However, I don’t see much value in it yet. Could you explain how this change improves the tool? It already uses (https://www.example.com/) to check proxy status, so I’m not sure why someone would want to check it against another URL. Wouldn’t the result remain the same? |
The results would not be the same. Some sites high profile sites like YouTube block some proxies, I know this because I tried it. I tried using proxies checked on https://www.example.com/ URL, later tried to use it on other websites and some did not work. Later I had to verify against the YouTube URL to get a valid proxy for my need. So proxies tested in default URL might be functional but might not be usable in every website. (At least in my experience). |
Ok, I see your point now—it makes sense. Next time, please mention these details in the PR. Once I get some time, I’ll test the code, and if everything looks good, I’ll merge the request. |
|
I'm sorry for the lack of details and also for for not tagging you. I did not notice that you were the maintainer. Cheers. |
|
After reviewing the tool once again, I encountered several minor issues. As a result, I have decided to rewrite the entire codebase from scratch rather than merging this pull request. However, I will make sure to address your feature request to enable proxy checks for specific URLs. Thank you for your valuable feedback |
2 participants
Added a feature for the user to input testing URL. User can input specific URL in this format (https://www.example.com) on which the proxies will be tested with. if the user input is empty, we fallback to the default URL which is https://www.example.com.