Fail with a friendlier error message when response has not been set #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
requested review from
WojciechNagorski and
drieseng
as code owners
|
Is there a possibility to add a test for that? |
|
I wrote a unit test, but there were several issues with using a mocked I felt that an integration test was a bit heavy for this, but I'll look at adding one anyway. |
Rob-Hague
commented
Nov 19, 2023
|
What about separate the two – Response null check
|
|
I'll just add the order by back. There is no need to waste time on this |
Rob-Hague
commented
Nov 27, 2023
Rob-Hague
force-pushed
the
keyboardinteractivenullresponse
branch
from
1edc34f to
dff8fe4
Compare
drieseng
approved these changes
Dec 2, 2023
WojciechNagorski
approved these changes
Dec 2, 2023
Closed
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in keyboard-interactive mode.
Closes #1237
Closes #382