Make SemaphoreLight AuthenticationConnection in Session.cs not static #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doing so we avoid needless waiting on a semaphore to signal if you have more than 3 simultaneous SSH clients in your application.
|
Wow, this might explain my low CPU usage and longer than expected wait times when connecting to 20+ devices at a time. Is the semaphore still needed at all? |
|
It is a security measurement. Personally, I would leave it there as a non-static field. |
|
It's done on master |
|
Nice. Thanks. Best wishes. |
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing so we avoid needless waiting on a semaphore to signal if you
have more than 3 simultaneous SSH clients in your application.