Skip to content

Alternative ip5306 battery level handling #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Alternative ip5306 battery level handling #49

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
330ad1f
Change from Component to PollingComponent
MichaKersloot Jan 26, 2023
b1e7ff5
Change from Component to PollingComponent
MichaKersloot Jan 26, 2023
eb4dafc
Change to device_class battery
MichaKersloot Jan 26, 2023
eb6de7b
Let home assistant handle the battery icons
MichaKersloot Jan 26, 2023
03b02e9
Update ip5306.cpp
MichaKersloot Feb 13, 2023
49788b3
Merge branch 'ssieb:master' into master
MichaKersloot Feb 28, 2023
7c7b1e3
Create __init__.py
MichaKersloot Feb 28, 2023
1a5c632
Create esp32_camera.cpp
MichaKersloot Feb 28, 2023
7569e20
Create esp32_camera.h
MichaKersloot Feb 28, 2023
af741cd
Trail fix for missing PSRAM
MichaKersloot Feb 28, 2023
6ca8ac1
Update to esphome 2023.4.4
MichaKersloot May 5, 2023
79c5a88
Compatible with esphome 2023.4.4
MichaKersloot May 5, 2023
3e80761
Compatible with esphome 2023.4.4
MichaKersloot May 5, 2023
8fa7852
Merge branch 'ssieb:master' into master
MichaKersloot Jun 6, 2025
fdf65dc
Update to newest version (2025.5.2)
MichaKersloot Jun 6, 2025
b1feaf9
Update to newest version (2025.5.2)
MichaKersloot Jun 6, 2025
43581c2
Update to newest version (2025.5.2)
MichaKersloot Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/ip5306/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import esphome.codegen as cg
import esphome.config_validation as cv
from esphome.components import binary_sensor, i2c, sensor
from esphome.const import CONF_ID, CONF_BATTERY_LEVEL, DEVICE_CLASS_VOLTAGE, ICON_PERCENT, UNIT_PERCENT
from esphome.const import CONF_ID, CONF_BATTERY_LEVEL, DEVICE_CLASS_BATTERY, ICON_BATTERY, UNIT_PERCENT

MULTI_CONF = True

Expand All @@ -18,7 +18,7 @@
cv.GenerateID(): cv.declare_id(IP5306),
cv.Optional(CONF_BATTERY_LEVEL): sensor.sensor_schema(
unit_of_measurement=UNIT_PERCENT,
icon=ICON_PERCENT,
device_class=DEVICE_CLASS_BATTERY,
accuracy_decimals=0,
),
cv.Optional(CONF_CHARGER_CONNECTED): binary_sensor.binary_sensor_schema(),
Expand Down
5 changes: 2 additions & 3 deletions components/ip5306/ip5306.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void IP5306::setup() {
}
}

void IP5306::loop() {
void IP5306::update() {
uint8_t data[2];
if (this->battery_level_ != nullptr) {
if (this->read_register(IP5306_REG_LEVEL, data, 1) != i2c::ERROR_OK) {
Expand All @@ -40,8 +40,7 @@ void IP5306::loop() {
case 0x80: value = 75; break;
case 0x00: value = 100; break;
}
if (!this->battery_level_->has_state() || (this->battery_level_->state != value))
this->battery_level_->publish_state(value);
this->battery_level_->publish_state(value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be indented a little bit more?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Fixed it in my fork, but not sure how to 'republish' this in this pull request.

}
if (this->read_register(IP5306_REG_READ0, data, 2) != i2c::ERROR_OK) {
ESP_LOGE(TAG, "unable to read status");
Expand Down
5 changes: 3 additions & 2 deletions components/ip5306/ip5306.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@
namespace esphome {
namespace ip5306 {

class IP5306 : public i2c::I2CDevice, public Component {
class IP5306 : public i2c::I2CDevice, public PollingComponent {
public:
IP5306() : PollingComponent(60000) {}
void setup() override;
void loop() override;
void update() override;

float get_setup_priority() const override;

Expand Down