feat: Allow borderRadius prop for RectShape. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemartinez37
force-pushed
the
Issue-195/rect-shape-custom-border-radius
branch
from
27a581f to
199123a
Compare
aemartinez37
force-pushed
the
Issue-195/rect-shape-custom-border-radius
branch
from
199123a to
9128723
Compare
aemartinez37
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for customizable corner rounding (border radius) for rectangle-shaped overlays in the spotlight tour feature. The main changes include extending the shape configuration interfaces and updating components to use the new
borderRadiusproperty, allowing for more flexible and visually appealing rectangle highlights.Shape configuration enhancements:
borderRadiusproperty toShapePropsinpackage/src/helpers/shape.tsto support customizable corner rounding for shapes.borderRadiusoption toShapeOptionsinpackage/src/lib/SpotlightTour.context.ts, including documentation and a default value of 4.Component and rendering updates:
TourOverlay.component.tsxto includeborderRadiuswith a default value, ensuring it is passed to shape components.borderRadiusprop fromTourOverlay.component.tsxto the shape component, enabling dynamic corner rounding.RectShape.component.tsxto use theborderRadiusprop for the rectangle'srxandrySVG attributes, replacing the previous hardcoded value. [1] [2]