feat: add territory SEO #2422
Open
feat: add territory SEO #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brymut
force-pushed
the
feat/add-sub-seo
branch
from
32b9015 to
60df93e
Compare
brymut
force-pushed
the
feat/add-sub-seo
branch
2 times, most recently
from
a6ed68a to
fdfa7c5
Compare
huumn
reviewed
Aug 29, 2025
lib/territory.js
Outdated
Comment on lines
32
to
77
|
|
||
| function cleanMarkdownText (text) { | ||
| if (!text) return '' | ||
|
|
||
| let cleaned = removeMd(text) | ||
| cleaned = cleaned | ||
| .replace(/\s+/g, ' ') // Replace multiple spaces with single space | ||
| .replace(/\[\[([^\]]+)\]\]\([^)]+\)/g, '$1') // Remove nested markdown links, keep inner text | ||
| .replace(/\[([^\]]+)\]\([^)]+\)/g, '$1') // Remove regular markdown links, keep text | ||
| .replace(/!\[([^\]]*)\]\([^)]+\)/g, '') // Remove images completely | ||
| .replace(/`([^`]+)`/g, '$1') // Remove code formatting | ||
| .replace(/\*\*([^*]+)\*\*/g, '$1') // Remove bold formatting | ||
| .replace(/\*([^*]+)\*/g, '$1') // Remove italic formatting | ||
| .trim() | ||
|
|
||
| return cleaned | ||
| } | ||
|
|
||
| function truncateAtSentenceBoundary (text, maxLength = 160) { | ||
| if (!text || text.length <= maxLength) return text | ||
| const sentences = text | ||
| .split(/[.!?]+/) | ||
| .map(s => s.trim()) | ||
| .filter(Boolean) | ||
|
|
||
| let result = '' | ||
| let currentLength = 0 | ||
|
|
||
| for (const sentence of sentences) { | ||
| const separator = result ? '. ' : '' | ||
| const newLength = currentLength + separator.length + sentence.length | ||
|
|
||
| if (newLength <= maxLength - 3) { | ||
| result += separator + sentence | ||
| currentLength = newLength | ||
| } else { | ||
| break | ||
| } | ||
| } | ||
| if (result) { | ||
| return result + '...' | ||
| } | ||
| // Fallback to simple truncation | ||
| return text.substring(0, maxLength - 3) + '...' | ||
| } | ||
|
|
There was a problem hiding this comment.
why not share the item seo stuff?
if the item seo stuff is lame in some way, improve and share it with territories. I think they should share seo - they are both mostly markdown documents.
There was a problem hiding this comment.
just following the issue spec
There was a problem hiding this comment.
why not share the item seo stuff?
Applied changes for users and item seo stuff too
brymut
force-pushed
the
feat/add-sub-seo
branch
from
fdfa7c5 to
2ee5a78
Compare
brymut
force-pushed
the
feat/add-sub-seo
branch
from
2ee5a78 to
8e8e8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove MD and images before creating a summary of the text in the SEO.
closes #2363
Tested using the ~AGORA description
Result
Tested using the ~AMA description
Result
Particularly short example (maybe images and Markdown being cleaned out make it too short)
Result
Checklist
Are your changes backward compatible? Please answer below:
Y
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Y
Did you introduce any new environment variables? If so, call them out explicitly here:
N