Add aria/testids to zap button for automation#2844
Open
kristapsk wants to merge 1 commit intostackernews:masterfrom
Open
Add aria/testids to zap button for automation#2844kristapsk wants to merge 1 commit intostackernews:masterfrom
kristapsk wants to merge 1 commit intostackernews:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added small accessibility + automation hooks to the zap (bolt) control in
components/upvote.js:data-testid="btn-zap"so headless/automation can reliably target the correct element (instead of guessing which SVG/icon was clicked).aria-labelandaria-pressedto expose state (zapped vs not zapped) to assistive tech and to make automated checks deterministic.role="button"+tabIndex={0}to make the interactive wrapper more semantically correct.Why: In headless/mobile-style UIs it’s easy to click the wrong icon (share/menu/etc.). These attributes reduce ambiguity and make it safer to automate flows (e.g., future NWC/zap testing) without changing existing zap behavior.
No behavior changes to zap amounts, tipping logic, or payment flows.
Screenshots
N/A (attribute-only change; no visible UI changes)
Additional Context
Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?
data-testidattributes to the zap modal input + submit button (inItemAct), but that’s out of scope here.Checklist
Are your changes backward compatible? Please answer below:
Yes. Additive attribute changes only; no API/db changes.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6/10 — ran
npm run lintandnpm test. No visible UI change expected; did not do full manual browser testing.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Not visually tested (no UI changes expected). Attributes should be mode-independent.
Did you introduce any new environment variables? If so, call them out explicitly here:
No.
Did you use AI for this? If so, how much did it assist you?
Yes — AI assisted with identifying minimal, low-risk attribute additions and implementing the patch (~70–80% assist).