Conversation
|
You'll want to give |
610e72b to
a699620
Compare
a699620 to
28f0fe5
Compare
|
Looks pretty nifty. I'll try to review in the next few days. In the meantime, do you have any questions or concerns about it? |
I don't think I left any options out except for deprecated ones, but I'm not entirely sure |
huumn
left a comment
There was a problem hiding this comment.
The code looks fine on a fast pass and everything works well. It feels a bit unintuitive but it's hard to pinpoint why.
Some concrete changes I'd like (some are questions):
- we should use primary colors for fewer buttons
- probably just save and copy, and toggles
- they can be distracting, like everything is a priority-1 button
- I'd like to link to and give a prominent shout out to Lopp's generator as inspiration
- how hard would it be to support more/older bitcoin versions?
- how might we best make updates to future versions?
|
I have GPT 5.4 xhigh do an adversarial review against Also before merge/deploying this I'd like create a way to test/validate we aren't (ever, ideally) generating invalid configurations (or ones that deviate from instruction).
|
Description
A clear and concise description of what you changed and why.
Added a new page that has a bitcoin config generator so the site has better marketing. Also added a tools section under the footer to access the bitcoin config generator.
Screenshots
Additional Context
Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?
Not sure if any options are missing or if there are any deprecated options present.
Checklist
Are your changes backward compatible? Please answer below:
Yes, I only made additions, I did not get rid of any existing functionality.
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. I verified all input fields create corresponding config change, verified front end was readable. Did not verify config files work on bitcoin node.
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
I tested on a mobile dev view on desktop.
Did you introduce any new environment variables? If so, call them out explicitly here:
None
Did you use AI for this? If so, how much did it assist you?
I made this almost entirely using AI.