fix: ensure hostname is short for maintenance #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
reviewed
Jan 3, 2025
jackhodgkiss
force-pushed
the
fix-fqdn-maintenance
branch
from
f9eaaea to
a760aaf
Compare
cityofships
force-pushed
the
fix-fqdn-maintenance
branch
from
05db110 to
16baaa0
Compare
cityofships
approved these changes
Aug 21, 2025
|
Are you sure this works correctly in all scenarios? It does the opposite change to #93 which was fixing Ceph deployments with FQDNs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If entering or exiting maintenance on a host whose hostname is full qualified may lead to failure as the FQDN does not match the name used by Ceph. Therefore, we should ensure we are using the short domain name instead.