Add support for job delay in CloudTasksQueue#184
Merged
marickvantuil merged 3 commits intostackkit:masterfrom Nov 14, 2025
Merged
Add support for job delay in CloudTasksQueue#184marickvantuil merged 3 commits intostackkit:masterfrom
marickvantuil merged 3 commits intostackkit:masterfrom
Conversation
Member
|
Thank you! In what scenario is the delay property missing when a job is dispatched? |
Contributor
Author
Thank you for your reply. We were noticing that delays were not working for Our code looks something like this, and it was dispatching all jobs immediately. I tried to add a test for this scenario. Please let me know your thoughts. |
Member
|
Thank you! Tagged this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Pass job delay to pushRaw in push method
Problem
When dispatching jobs using the
push()method, the delay property from the job object was not being passed topushRaw(). This meant that jobs with a configured delay would be executed immediately instead of being scheduled for the specified time.Solution
Updated the
push()method to extract thedelayproperty from the job object (if present) and include it in the options array passed topushRaw(). This ensures that delayed jobs are properly scheduled with their intended execution time.The implementation now:
delaypropertyrelease()method which already follows this patternChanges
src/CloudTasksQueue.phplines 135-142pushRaw()This brings the
push()method in line with how delays are handled in therelease()method, ensuring consistent behavior across the queue system.