fix: weird behavior with groups when restarting server #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantord
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where group-aware optimistic updates were hardcoded to use the 'default' group instead of respecting the actual group context. The fix ensures that when restarting servers, the optimistic UI updates correctly target the appropriate group's query cache.
- Updates query cache operations to be group-aware instead of hardcoded to 'default'
- Modifies restart server mutations to accept and use group parameters
- Refactors optimistic update logic to handle multiple query cache entries per group
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
renderer/src/routes/group.$groupName.tsx |
Conditionally uses group name based on sidebar visibility |
renderer/src/features/mcp-servers/hooks/use-mutation-restart-server.ts |
Major refactor to support group-aware optimistic updates and cache management |
renderer/src/features/mcp-servers/hooks/__tests__/use-mutation-restart-server.test.ts |
Removes unused test data and imports |
renderer/src/features/mcp-servers/components/card-mcp-server/index.tsx |
Passes group parameter to restart server mutation |
main/src/graceful-exit.ts |
Changes return type from string array to CoreWorkload array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context https://stacklok.slack.com/archives/C091GRYAG49/p1760033135113959?thread_ts=1760003349.102839&cid=C091GRYAG49
Make optimistic updates group-aware (use-mutation-restart-server.ts, graceful-exit.ts); (Optimistic updates were hardcoded to group: 'default)