fix: Add option to list from remote cluster #1433
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient configuration - Introduced a new `--runtime` flag for the `thv list` command to specify the container runtime (docker, kubernetes). - Updated the command's documentation to reflect the new flag. - Enhanced the Kubernetes client to fall back to remote configuration if in-cluster configuration fails, improving error handling and logging. - Added tests to ensure proper fallback behavior for Kubernetes client configuration. Signed-off-by: [Daniele Martinoli] <[email protected]> Signed-off-by: Daniele Martinoli <[email protected]>
jhrozek
reviewed
Aug 14, 2025
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get user home directory: %w", err) | ||
| } | ||
| kubeconfigPath = homeDir + "/.kube/config" |
There was a problem hiding this comment.
hmm, this will not work on Windows will it? I was browsing through the clientcmd package because I was not familiar with it and noticed that it exports RecommendedHomeFile, could we use that?
| @@ -401,6 +480,7 @@ func (c *Client) ListWorkloads(ctx context.Context) ([]runtime.ContainerInfo, er | |||
|
|
|||
| // List pods with the toolhive label | |||
| namespace := getCurrentNamespace() | |||
| fmt.Printf("listing pods in namespace %s", namespace) | |||
There was a problem hiding this comment.
I think this was left here by accident?
| var err error | ||
|
|
||
| // First, try to create an in-cluster config | ||
| config, err = rest.InClusterConfig() | ||
| if err != nil { |
There was a problem hiding this comment.
Would it make sense to only do the fallback on rest.ErrNotInCluster?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for #1429
thv listcommand to limit the extent of changesKeeping in draft mode until there's some decision about the other commands.