[MIPRO v2] Fix parameter update order in MIPROv2.compile
#8811
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move "# Update max demos if specified" to the front of setting "zeroshot_opt" in MIPRO_v2 compile function
There was a problem hiding this comment.
@klopsahlong qq - do we expect to override the self.max_bootstrapped_demos at every call? maybe we should keep the attribute value unchanged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
compilefunction ofMIPROv2, the parametersmax_bootstrapped_demosandmax_labeled_demosare intended to override the defaults and update thezeroshot_optvalue.However, in the main branch,
zeroshot_optis assigned beforeself.max_bootstrapped_demosandself.max_labeled_demosare updated. This makes the passed-in parameters ineffective.This PR fixes the issue by moving the update of
self.max_bootstrapped_demosandself.max_labeled_demosbefore assigningzeroshot_opt.