Reddit Source downloader #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subreddit Posts - completed - Subreddit Votes - completed - Subreddit Comments - in development - Output fields are based on Dagster process
apentori
reviewed
Jul 17, 2025
Comment on lines
192
to
196
| def __init__(self, subreddit: str, authenticator: requests.auth.AuthBase, **kwargs): | ||
| super().__init__(parent=SubredditPosts, **kwargs) | ||
|
|
||
| self.subreddit = subreddit | ||
| self.parent = SubredditPosts(self.subreddit, authenticator) |
There was a problem hiding this comment.
If you put subreddit in APIStream you wont have to declare the init function
- Add the votes for the comments
apentori
approved these changes
Jul 21, 2025
| @@ -129,16 +154,14 @@ def next_page_token(self, response: requests.Response) -> Optional[dict[str, Any | |||
|
|
|||
|
|
|||
|
|
|||
| class SubredditVotes(SubredditPosts): | |||
| class PostsVotes(Posts): | |||
There was a problem hiding this comment.
Shouldn't this be a HttpSubStream ?
There was a problem hiding this comment.
PostsVotes should be running independently. Votes are dynamic - can change any time. If PostsVotes is its own stream we can the monitor its engagement. If we want to do get the latest value then the data will have to be transformed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to: