fix fulu builder api changes #7340

agnxsh · 2025-07-29T10:19:30Z

No description provided.

github-actions · 2025-07-29T12:41:58Z

Unit Test Results

      15 files +      3   2 650 suites +530 1h 18m 19s ⏱️ + 19m 30s
  6 634 tests ±      0   6 076 ✔️ ±      0 558 💤 ±  0 0 ❌ ±0
45 676 runs +9 136 44 894 ✔️ +9 066 782 💤 +70 0 ❌ ±0

Results for commit 0bab4ba. ± Comparison against base commit 2283585.

♻️ This comment has been updated with latest results.

…pose on behalf of BN

…fixx

…pose on behalf of BN

…fixx

tersec · 2025-08-03T05:22:44Z

beacon_chain/el/engine_api_conversions.nim

@@ -233,11 +233,11 @@ func asConsensusTypeFulu*(
    # The `mapIt` calls below are necessary only because we use different distinct
    # types for KZG commitments and Blobs in the `web3` and the `deneb` spec types.
    # Both are defined as `array[N, byte]` under the hood.
-    blobsBundle: deneb.BlobsBundle(
+    blobsBundle: fulu.BlobsBundleV2(


This isn't accurate; GetPayloadV4 uses BlobsBundleV1: https://github.com/ethereum/execution-apis/blob/v1.0.0-beta.4/src/engine/prague.md#engine_getpayloadv4

tersec · 2025-08-03T05:31:04Z

beacon_chain/spec/state_transition.nim

@@ -570,7 +570,7 @@ proc makeBeaconBlockWithRewards*(
               hash_tree_root(validator_changes.proposer_slashings),
               hash_tree_root(validator_changes.electra_attester_slashings),
               hash_tree_root(
-                 List[electra.Attestation, Limit MAX_ATTESTATIONS](
+                 List[electra.Attestation, Limit MAX_ATTESTATIONS_ELECTRA](


This is the actual fix.

tersec · 2025-08-03T05:32:29Z

beacon_chain/spec/eth2_apis/rest_types.nim

@@ -550,6 +550,7 @@ type
  GetHeaderResponseElectra* = DataVersionEnclosedObject[electra_mev.SignedBuilderBid]
  GetHeaderResponseFulu* = DataVersionEnclosedObject[fulu_mev.SignedBuilderBid]
  SubmitBlindedBlockResponseElectra* = DataVersionEnclosedObject[electra_mev.ExecutionPayloadAndBlobsBundle]
+  SubmitBlindedBlockResponseFulu* = DataVersionEnclosedObject[fulu_mev.ExecutionPayloadAndBlobsBundle]


Per ethereum/builder-specs#123 the v2 API which Nimbus now uses for Fulu instead of the deprecated v1 API "does not return the execution payload and blobs".

There's no decoding to do, unlike Pectra. So this SubmitBlindedBlockResponseFulu type is neither necessary nor useful.

tersec · 2025-08-03T05:33:17Z

beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim

@@ -270,6 +270,7 @@ RestJson.useDefaultSerializationFor(
  fulu_mev.BlindedBeaconBlock,
  fulu_mev.BlindedBeaconBlockBody,
  fulu_mev.BuilderBid,
+  fulu_mev.ExecutionPayloadAndBlobsBundle,


Because SubmitBlindedBlockResponseFulu isn't used, neither is this.

tersec · 2025-08-03T05:34:15Z

beacon_chain/el/engine_api_conversions.nim

      commitments: KzgCommitments.init(
        payload.blobsBundle.commitments.mapIt(
          kzg_abi.KzgCommitment(bytes: it.data))),
-      proofs: KzgProofs.init(
+      proofs: KzgProofsV2.init(


Also not accurate.

tersec · 2025-08-03T05:38:20Z

beacon_chain/rpc/rest_beacon_api.nim

@@ -1042,7 +1042,8 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) =
            doAssert strictVerification notin node.dag.updateFlags
            return RestApiResponse.jsonError(Http400, InvalidBlockObjectError)

-          when consensusFork >= ConsensusFork.Deneb:
+          when consensusFork >= ConsensusFork.Deneb and


Two points:

https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlock shows " Warning: Deprecated". That is, I'll remove (Http410) this entire handler as soon as feasible come Fulu. It doesn't matter if it works under Fulu; it will never have to.

Even otherwise, this endpoint isn't about blinded blocks, but non-MEV blocks, and those should be sending their blob/column sidecars somewhere.

But the first point is more important. There's no reason to change this to work in Fulu, nor should it be changed.

tersec · 2025-08-03T05:41:19Z

beacon_chain/spec/forks.nim

@@ -489,7 +489,8 @@ template kind*(
      fulu.MsgTrustedSignedBeaconBlock |
      fulu.TrustedSignedBeaconBlock |
      fulu_mev.SignedBlindedBeaconBlock |
-      fulu_mev.SignedBuilderBid]): ConsensusFork =
+      fulu_mev.SignedBuilderBid |
+      fulu_mev.ExecutionPayloadAndBlobsBundle]): ConsensusFork =


Shouldn't be used either.

I removed all this, for good reason, back in #7308

There's still no actual block/blob return from submitBlindedBlock in Fulu, so all of this is pointless. The stateroot bug was related, as far as it seems so far, in the construction of the shim block in state_transition, and that fix is elsewhere. There's still nothing to decode from the relay for Fulu, aside from checking the 202-or-not-204 HTTP return.

tersec · 2025-08-03T05:41:44Z

beacon_chain/spec/mev/fulu_mev.nim

@@ -69,11 +70,17 @@ type
    message*: BlindedBeaconBlock
    signature*: ValidatorSig

+  # https://github.com/ethereum/builder-specs/blob/ae1d97d080a12bfb7ca248b58fb1fc6b10aed02e/specs/fulu/builder.md#executionpayloadandblobsbundle
+  ExecutionPayloadAndBlobsBundle* = object


See elsewhere, not useful/necessary.

tersec · 2025-08-21T07:30:51Z

beacon_chain/validators/beacon_validators.nim

    doAssert engineBid.blobsBundle.commitments ==
      forkyBlck.body.blob_kzg_commitments
    ResultType.ok((
      blck: consensusFork.MaybeBlindedBeaconBlock(
        isBlinded: false,
        data: consensusFork.BlockContents(
          `block`: forkyBlck,
-          kzg_proofs: engineBid.blobsBundle.proofs,
+          kzg_proofs: KzgProofs(engineBid.blobsBundle.proofs),


/github-runner/github-runner-node-01/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/validators/beacon_validators.nim(2076, 32) Hint: conversion from KzgProofs to itself is pointless [ConvFromXtoItselfNotNeeded]

tersec · 2025-08-21T07:32:50Z

beacon_chain/validators/beacon_validators.nim

+        isBlinded: false,
+        data: consensusFork.BlockContents(
+          `block`: forkyBlck,
+          kzg_proofs: KzgProofsV2(engineBid.blobsBundleV2.proofs),


/github-runner/github-runner-node-01/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/validators/beacon_validators.nim(2064, 34) Hint: conversion from KzgProofsV2 to itself is pointless [ConvFromXtoItselfNotNeeded]

tersec · 2025-08-21T07:33:49Z

beacon_chain/validators/beacon_validators.nim

          res.get()
      signedBlock = consensusFork.SignedBeaconBlock(
        message: forkyBlck, signature: signature, root: blockRoot)
      blobsOpt =
        when consensusFork >= ConsensusFork.Deneb:
          Opt.some(signedBlock.create_blob_sidecars(
-            engineBid.blobsBundle.proofs, engineBid.blobsBundle.blobs))
+            KzgProofs(engineBid.blobsBundle.proofs), engineBid.blobsBundle.blobs))


/github-runner/github-runner-node-01/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/validators/beacon_validators.nim(1249, 22) Hint: conversion from KzgProofs to itself is pointless [ConvFromXtoItselfNotNeeded]

tersec · 2025-08-27T10:03:37Z

Overtaken by events.

agnxsh added 2 commits July 29, 2025 15:45

fix fulu builder api changes

709725d

fix fulu builder api changes

0b4c793

agnxsh force-pushed the fixx branch from 709725d to 0b4c793 Compare July 29, 2025 10:19

agnxsh added 8 commits July 30, 2025 13:41

handle proposal can now return no block ref when relay chooses to pro…

cd6e4a2

…pose on behalf of BN

resolved merge conflict

c2b71b3

resolved merge conflict

3dfe6e2

Merge branch 'fixx' of https://github.com/status-im/nimbus-eth2 into …

3d609f5

…fixx

further cleanups and clarifications to fulu builder api

cd8bfc0

fix fulu builder api changes

7f86996

handle proposal can now return no block ref when relay chooses to pro…

412f3d0

…pose on behalf of BN

further cleanups and clarifications to fulu builder api

b70705c

agnxsh force-pushed the fixx branch from cd8bfc0 to b70705c Compare July 30, 2025 16:06

agnxsh added 4 commits July 30, 2025 21:38

fixes

b9c2eb4

Merge branch 'fixx' of https://github.com/status-im/nimbus-eth2 into …

063285f

…fixx

fix copyright year

25b65f4

fix further stuff

a156f18

tersec reviewed Aug 3, 2025

View reviewed changes

tersec mentioned this pull request Aug 4, 2025

adopt columns into the BN, except column syncing #6945

Open

Merge branch 'unstable' into fixx

0bab4ba

tersec reviewed Aug 21, 2025

View reviewed changes

tersec closed this Aug 27, 2025

tersec reopened this Aug 27, 2025

agnxsh closed this Aug 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix fulu builder api changes #7340

fix fulu builder api changes #7340

Uh oh!

agnxsh commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 3, 2025

Uh oh!

tersec Aug 21, 2025

Uh oh!

tersec Aug 21, 2025

Uh oh!

tersec Aug 21, 2025

Uh oh!

tersec commented Aug 27, 2025

Uh oh!

Uh oh!

fix fulu builder api changes #7340

fix fulu builder api changes #7340

Uh oh!

Conversation

agnxsh commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tersec commented Aug 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025 •

edited

Loading