-
Notifications
You must be signed in to change notification settings - Fork 44
Integrate LI.FI provider #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta/wallet
Are you sure you want to change the base?
Integrate LI.FI provider #716
Conversation
|
Jenkins BuildsClick to see older builds (6)
|
@JulesFiliot is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
87e9241
to
14a52cd
Compare
@JulesFiliot could you please share an update on this one? |
Hey @felicio, yes! Sorry for being silent, I've worked a lot on it, including every day of last week. I'll push all my local code today. It's honestly a lot of work because I have to update the connector, wallet API, ethereum transactions handler ( So right now I successfully implemented:
What I'm still working on:
It has been a lot of trials and errors so my code is a bit dirty, I need to clean it before pushing. I'll try my best to integrate bridging + swapping at the same time today. |
@felicio (cc @jkbktl), I just pushed my changes.
What should be improved:
|
Hey @jkbktl @felicio I forgot to ask if you could review the PR please 🙏 ? I don't have the rights to add reviewers to the PR. As I mentioned here #716 (comment) there are still things that could be improved but I think the diff from this PR is already huge and I already spent a lot of time working on this so I'd prefer if we can review and ship this. The core features of the widget are working so I would say this is acceptable to ship as is. |
71ef252
to
54b8933
Compare
Hey @felicio I see you did some edits on this PR, do you need any input/support from me? |
closes #697