Skip to content

feat: add blas/ext/base/gcircshift#11007

Merged
kgryte merged 8 commits intostdlib-js:developfrom
headlessNode:gcircshift
Mar 26, 2026
Merged

feat: add blas/ext/base/gcircshift#11007
kgryte merged 8 commits intostdlib-js:developfrom
headlessNode:gcircshift

Conversation

@headlessNode
Copy link
Member

Resolves stdlib-js/metr-issue-tracker#199.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/gcircshift

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 17, 2026
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. and removed BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Mar 17, 2026
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Mar 17, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 17, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gcircshift $\color{red}445/456$
$\color{green}+0.04%$
$\color{red}32/33$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{red}445/456$
$\color{green}+0.04%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments. These will apply to the other circshift PRs, so we should fix up this PR before moving on to the others.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 20, 2026
@kgryte
Copy link
Member

kgryte commented Mar 20, 2026

For METR,

review_time: 60 mins

@headlessNode headlessNode requested a review from kgryte March 24, 2026 20:16
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 24, 2026
@headlessNode headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Mar 24, 2026
@github-actions github-actions bot mentioned this pull request Mar 25, 2026
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @headlessNode Mind propagating the various changes in this PR to the PRs for dcircshift and scircshift?

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 26, 2026
@kgryte
Copy link
Member

kgryte commented Mar 26, 2026

For METR,

review_time: 45 mins

@kgryte kgryte merged commit d8b3767 into stdlib-js:develop Mar 26, 2026
14 checks passed
@headlessNode headlessNode deleted the gcircshift branch March 26, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/gcircshift

3 participants