Skip to content

fix: correct grammar in ndarray type test comments#11154

Merged
kgryte merged 1 commit intostdlib-js:developfrom
mvanhorn:osc/11152-fix-grammar-comment
Mar 27, 2026
Merged

fix: correct grammar in ndarray type test comments#11154
kgryte merged 1 commit intostdlib-js:developfrom
mvanhorn:osc/11152-fix-grammar-comment

Conversation

@mvanhorn
Copy link
Contributor

@mvanhorn mvanhorn commented Mar 26, 2026

Summary

Fixes a grammatical error in TypeScript type test comments for @stdlib/ndarray/base/ones-like and @stdlib/ndarray/base/zeros-like.

Changes

Before: "The compiler throws an error if the function is provided a first argument is not an ndarray which has a recognized/supported data type"

After: "The compiler throws an error if the function is provided a first argument which is not an ndarray having a recognized/supported data type"

Files Modified

  • lib/node_modules/@stdlib/ndarray/base/ones-like/docs/types/test.ts (line 44)
  • lib/node_modules/@stdlib/ndarray/base/zeros-like/docs/types/test.ts (line 44)

Closes #11152

This contribution was developed with AI assistance (Claude Code).


Fix grammatical error in compiler error description comments:

Before: "provided a first argument is not an ndarray which has"
After:  "provided a first argument which is not an ndarray having"

Applied to both `ones-like` and `zeros-like` type test files.

Closes stdlib-js#11152

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 26, 2026
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 26, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/ones-like $\color{green}111/111$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}111/111$
$\color{green}+100.00%$
ndarray/base/zeros-like $\color{green}142/142$
$\color{green}+100.00%$
$\color{green}8/8$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}142/142$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Mar 26, 2026

@mvanhorn Mind addressing the comment above? In short, every OP needs to include the acknowledgement.

@github-actions github-actions bot mentioned this pull request Mar 26, 2026
@mvanhorn
Copy link
Contributor Author

Added - should be in the description now.

@kgryte kgryte merged commit 762f410 into stdlib-js:develop Mar 27, 2026
52 of 53 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 27, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels Mar 27, 2026
@mvanhorn
Copy link
Contributor Author

Thanks for the quick reviews and merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit d200536)

3 participants