fix: correct grammar in ndarray type test comments#11154
fix: correct grammar in ndarray type test comments#11154kgryte merged 1 commit intostdlib-js:developfrom
Conversation
Fix grammatical error in compiler error description comments: Before: "provided a first argument is not an ndarray which has" After: "provided a first argument which is not an ndarray having" Applied to both `ones-like` and `zeros-like` type test files. Closes stdlib-js#11152 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@mvanhorn Mind addressing the comment above? In short, every OP needs to include the acknowledgement. |
|
Added - should be in the description now. |
|
Thanks for the quick reviews and merges! |
Summary
Fixes a grammatical error in TypeScript type test comments for
@stdlib/ndarray/base/ones-likeand@stdlib/ndarray/base/zeros-like.Changes
Before: "The compiler throws an error if the function is provided a first argument is not an ndarray which has a recognized/supported data type"
After: "The compiler throws an error if the function is provided a first argument which is not an ndarray having a recognized/supported data type"
Files Modified
lib/node_modules/@stdlib/ndarray/base/ones-like/docs/types/test.ts(line 44)lib/node_modules/@stdlib/ndarray/base/zeros-like/docs/types/test.ts(line 44)Closes #11152
This contribution was developed with AI assistance (Claude Code).