-
-
Notifications
You must be signed in to change notification settings - Fork 860
chore: add a poc script for generating dtype
combinations
#7773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Please note that the meta-data in scalar math kernels of |
for ( i = 0; i < matches.length; i++ ) { | ||
// Skip complex32, float16, uint8c and int16 as we don't support them yet... | ||
if ( matches[ i ][ 0 ] === 'complex32' || | ||
matches[ i ][ 0 ] === 'int16' || | ||
matches[ i ][ 0 ] === 'float16' || | ||
matches[ i ][ 0 ] === 'uint8c' || | ||
matches[ i ][ 1 ] === 'complex32' || | ||
matches[ i ][ 1 ] === 'int16'|| | ||
matches[ i ][ 1 ] === 'float16' || | ||
matches[ i ][ 1 ] === 'uint8c' ) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are skipping those dtypes
which are currently not present here: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/base/unary#c-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script generates the following matches
table, which contains only the valid combinations:
Generated 21 matches
[
[
'complex64',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_c_z_as_z_z'
],
[
'float32',
'complex64',
'@stdlib/math/base/special/cceilf',
true,
'complex64',
'complex64',
'stdlib_base_cceilf',
'stdlib_ndarray_f_c_as_c_c'
],
[
'float32',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_f_z_as_z_z'
],
[
'float32',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_f_d_as_d_d'
],
[
'float64',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_d_z_as_z_z'
],
[
'int32',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_i_z_as_z_z'
],
[
'int32',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_i_d_as_d_d'
],
[
'int8',
'complex64',
'@stdlib/math/base/special/cceilf',
true,
'complex64',
'complex64',
'stdlib_base_cceilf',
'stdlib_ndarray_s_c_as_c_c'
],
[
'int8',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_s_z_as_z_z'
],
[
'int8',
'float32',
'@stdlib/math/base/special/ceilf',
true,
'float32',
'float32',
'stdlib_base_ceilf',
'stdlib_ndarray_s_f_as_f_f'
],
[
'int8',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_s_d_as_d_d'
],
[
'uint16',
'complex64',
'@stdlib/math/base/special/cceilf',
true,
'complex64',
'complex64',
'stdlib_base_cceilf',
'stdlib_ndarray_t_c_as_c_c'
],
[
'uint16',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_t_z_as_z_z'
],
[
'uint16',
'float32',
'@stdlib/math/base/special/ceilf',
true,
'float32',
'float32',
'stdlib_base_ceilf',
'stdlib_ndarray_t_f_as_f_f'
],
[
'uint16',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_t_d_as_d_d'
],
[
'uint32',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_u_z_as_z_z'
],
[
'uint32',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_u_d_as_d_d'
],
[
'uint8',
'complex64',
'@stdlib/math/base/special/cceilf',
true,
'complex64',
'complex64',
'stdlib_base_cceilf',
'stdlib_ndarray_b_c_as_c_c'
],
[
'uint8',
'complex128',
'@stdlib/math/base/special/cceil',
true,
'complex128',
'complex128',
'stdlib_base_cceil',
'stdlib_ndarray_b_z_as_z_z'
],
[
'uint8',
'float32',
'@stdlib/math/base/special/ceilf',
true,
'float32',
'float32',
'stdlib_base_ceilf',
'stdlib_ndarray_b_f_as_f_f'
],
[
'uint8',
'float64',
'@stdlib/math/base/special/ceil',
true,
'float64',
'float64',
'stdlib_base_ceil',
'stdlib_ndarray_b_d_as_d_d'
]
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the generated functions here: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/ndarray/base/unary#c-apis, and all of them do exist.
Signed-off-by: Gunj Joshi <[email protected]>
Resolves None.
Description
This pull request:
dtype
pairs.src/addon.c
andlib/types.js
.package.json
ofceil
,ceilf
,cceil
andcceilf
. For now, I have only modified the relevantdtype
fields in the meta-data of these 4 packages.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers