-
-
Notifications
You must be signed in to change notification settings - Fork 906
chore: fix JavaScript lint errors (issue #8235) (remove all unused no-new-wrappers disables in @stdlib/assert examples) #8240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
The above coverage report was generated for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8235.
Description
This pull request:
Rationale:
Selection criteria:
Remove the directive when:
- no new Number/String/Boolean is used; or
- new Number/Boolean is used but the corresponding constructor is locally shadowed via @stdlib/*/ctor, so no-new-wrappers does not apply.
Keep the directive when:
- the example intentionally uses a global wrapper (e.g., new String(...)) and no local shadow exists, meaning the rule would trigger without the disable.
One special case:
- is-finite/examples/index.js: the disable line contained no-new-wrappers, stdlib/no-redeclare; only no-new-wrappers was unused, so it was dropped and stdlib/no-redeclare retained.
Net effect:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers