Skip to content

Conversation

@WillyEverGreen
Copy link
Contributor

@WillyEverGreen WillyEverGreen commented Oct 26, 2025

Resolves #8294

Description

This pull request fixes several JavaScript linting failures detected by CI. The changes make small, low-risk fixes to linter rule implementations and examples so that automated linting and doctest checks pass.

Change summary:

  • Fixed variable ordering and unused variable handling in lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-license-header-year/lib/main.js.
  • Replaced disallowed
    ew Array() usages with array literals in lib/node_modules/@stdlib/array/generic/benchmark/benchmark.fast_elements_array_length_heuristic.js.
  • Made citation-reference conversion robust when external tools (e.g., pandoc) are not available by writing an empty output file on conversion failure: lib/node_modules/@stdlib/_tools/bib/citation-reference/lib/sync.js.

How I verified:

  • Ran the modified examples locally to confirm deterministic outputs for doctests.
  • Ran ESLint locally where possible; pushed fixes and opened this PR for CI verification across the full repo.

Related Issues

Checklist

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Oct 26, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Oct 26, 2025
WillyEverGreen added a commit to WillyEverGreen/stdlib that referenced this pull request Oct 26, 2025
@WillyEverGreen WillyEverGreen force-pushed the chore/fix-js-lint-8294 branch 2 times, most recently from 136321d to 2999155 Compare October 26, 2025 11:28
@WillyEverGreen WillyEverGreen deleted the chore/fix-js-lint-8294 branch October 26, 2025 11:36
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants