-
-
Notifications
You must be signed in to change notification settings - Fork 957
feat: add stats/base/ndarray/range-by
#8497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats/base/ndarray/range-by
#8497
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/ndarray/range-by
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iampratik13 Thank you for opening this PR; however, most of this PR is not correct. You should be matching the API of https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/ndarray/max-by exactly apart from swapping max-by for range-by. What you've done here is not what is desired.
|
Thanks for the feedback @kgryte , I realized that and I’m currently updating the implementation to match the max-by API exactly. I’ll push the corrected version shortly. |
|
@kgryte Thanks for the feedback — I’ve made all the suggested changes. |
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/stats/base/ndarray/range-by/package.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after some additional clean-up.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed
Resolves None.
Description
What is the purpose of this pull request?
This pull request:
feat: add stats/base/ndarray/range-by
Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
None
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers