Skip liballocs-related preprocessing changes if -E seen
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Small code-review comment: instead of a new |
|
Of course! Change incoming. |
Just realised it'll likely be set to allocscc, and that could cause issues. Not falling back to `$CC` makes the behaviour the same as when we're not only preprocessing, so matching that behaviour is probably advisable anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling
gnutlswe saw the configure script use the preprocessor to determine flags to pass to the compiler. It did this by preprocessing a list of prospective args to$CC, and using the preprocessor to determine which of those were valid. It takes the output from the preprocessor --- a list of "valid" flags to$CC--- and supplies that to future calls to$CC.Because
allocsccinjects liballocs-related machinery into the code it compiles, the output ofallocscc's preprocessor contains liballocs-related C code. However,gnutlsuses the preprocessor on something that isn't really C code! When the list of arguments was passed to later calls to$CC, the C code injected byallocsccwould gum up the works.#118 tracks this.
This PR disables any liballocs-related work if we see
-Ein allocscc's arguments.