Skip to content

#114 Clickhouse Dialect GetTableColumns Fails To Return ColumnTypes #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#114 Clickhouse Dialect GetTableColumns Fails To Return ColumnTypes #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions db_changes/db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,16 @@ func (l *Loader) getTablesFromSchema(schemaName string) (map[[2]string][]*sql.Co
ORDER BY table_schema, table_name
`

if l.dsn.Driver() == "clickhouse" {
query = `
SELECT database AS table_schema, name AS table_name
FROM system.tables
WHERE database = ?
AND engine NOT IN ('View', 'MaterializedView', 'Buffer')
ORDER BY table_schema, table_name
`
}

rows, err := l.DB.Query(query, schemaName)
if err != nil {
return nil, fmt.Errorf("querying tables: %w", err)
Expand Down
4 changes: 0 additions & 4 deletions db_changes/db/dsn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ func (c *DSN) ConnString() string {
// In the old code, of there was options set and the host was localhost, we were switching
// to host 127.0.0.1 + change of scheme to http/https, let's keep that for now
host = "127.0.0.1"
scheme = "http"
if c.Options.Get("secure") == "true" {
scheme = "https"
}
}

baseURL := fmt.Sprintf("%s://%s:%s@%s:%d/%s", scheme, c.Username, c.Password, host, c.Port, c.Database)
Expand Down
Loading