Skip to content

Fixed volume mount missing required name field #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixed volume mount missing required name field #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59bc0a9
Fixed
tuteng Jun 6, 2025
c43462e
Fixed detector token
tuteng Jun 6, 2025
d4cf875
Fixed
tuteng Jun 6, 2025
3620317
Fixed
tuteng Jun 6, 2025
9e58be2
Fixed
tuteng Jun 6, 2025
a41332c
Merge branch 'master' into fixed/volume-mount-name-missing-name-field
tuteng Jun 6, 2025
69b58f2
Fixed token
tuteng Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@ spec:
{{- end }}
{{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }}
-auth-plugin token
-auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}"
-auth-params "{\"file\":\"$brokerClientAuthenticationParameters\"}"
{{- end }}
-service-url {{ template "pulsar.detector.serviceUrl" . }}
-webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
{{- else }}
args:
- >
bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"file\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
{{- end }}
{{- if .Values.pulsar_detector.resources }}
resources: {{- toYaml .Values.pulsar_detector.resources | nindent 10 }}
Expand All @@ -132,21 +132,31 @@ spec:
env:
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- name: brokerClientAuthenticationParameters
valueFrom:
secretKeyRef:
name: {{ .Release.Name }}-token-admin
key: TOKEN
value: "/mnt/token/TOKEN"
{{- end }}
{{- if .Values.pulsar_detector.extraEnv }}
{{- toYaml .Values.pulsar_detector.extraEnv | nindent 10 }}
{{- end }}
{{- if .Values.pulsar_detector.extraVolumeMounts }}
{{- if or .Values.pulsar_detector.extraVolumeMounts (and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled) }}
volumeMounts:
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- mountPath: /mnt/token
name: detector-token
readOnly: true
{{- end }}
{{- if .Values.pulsar_detector.extraVolumeMounts }}
{{- toYaml .Values.pulsar_detector.extraVolumeMounts | nindent 10 }}
{{- end }}
{{- end }}
volumes:
- name: tmp
emptyDir: {}
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- name: detector-token
secret:
secretName: {{ .Release.Name }}-token-admin
defaultMode: 420
{{- end }}
{{- if .Values.pulsar_detector.extraVolumes }}
{{- toYaml .Values.pulsar_detector.extraVolumes | nindent 8 }}
{{- end }}
Expand Down
24 changes: 17 additions & 7 deletions charts/sn-platform/templates/detector/pulsar-detector-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@ spec:
{{- end }}
{{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }}
-auth-plugin token
-auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}"
-auth-params "{\"file\":\"$brokerClientAuthenticationParameters\"}"
{{- end }}
-service-url {{ template "pulsar.detector.serviceUrl" . }}
-webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
{{- else }}
args:
- >
bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"token\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
bin/pulsar-detector -service-url {{ template "pulsar.detector.serviceUrl" . }} -webservice-url {{ template "pulsar.detector.webServiceUrl" . }} {{- if and .Values.auth.authentication.enabled (eq .Values.auth.authentication.provider "jwt") }} -auth-plugin token -auth-params "{\"file\":\"$brokerClientAuthenticationParameters\"}" {{- end }};
{{- end }}
{{- if .Values.pulsar_detector.resources }}
resources: {{- toYaml .Values.pulsar_detector.resources | nindent 10 }}
Expand All @@ -139,21 +139,31 @@ spec:
{{- end }}
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- name: brokerClientAuthenticationParameters
valueFrom:
secretKeyRef:
name: {{ .Release.Name }}-token-admin
key: TOKEN
value: "/mnt/token/TOKEN"
{{- end }}
{{- if .Values.pulsar_detector.extraEnv }}
{{- toYaml .Values.pulsar_detector.extraEnv | nindent 10 }}
{{- end }}
{{- if .Values.pulsar_detector.extraVolumeMounts }}
{{- if or .Values.pulsar_detector.extraVolumeMounts (and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled) }}
volumeMounts:
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- mountPath: /mnt/token
name: detector-token
readOnly: true
{{- end }}
{{- if .Values.pulsar_detector.extraVolumeMounts }}
{{- toYaml .Values.pulsar_detector.extraVolumeMounts | nindent 10 }}
{{- end }}
{{- end }}
volumes:
- name: tmp
emptyDir: {}
{{- if and .Values.auth.authentication.enabled .Values.auth.authentication.jwt.enabled }}
- name: detector-token
secret:
secretName: {{ .Release.Name }}-token-admin
defaultMode: 420
{{- end }}
{{- if .Values.pulsar_detector.extraVolumes }}
{{- toYaml .Values.pulsar_detector.extraVolumes | nindent 8 }}
{{- end }}
Expand Down
Loading