Skip to content

Refactor producer send paths to shrink future sizes #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor producer send paths to shrink future sizes #348

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b649482
refactor(producer): shrink async futures and release batch lock befor…
ChrisWrenDev Aug 20, 2025
e6044e6
test(producer): unit tests for batching and message conversion
ChrisWrenDev Aug 20, 2025
14f8ac2
chore(producer): revert unit tests and lock contention changes
ChrisWrenDev Aug 27, 2025
1c2e218
chore(producer): reverted ensure_connected and start_send_once helpers
ChrisWrenDev Aug 28, 2025
3268d17
chore: resolve merge conflicts between fix/producer-small-futures and…
ChrisWrenDev Aug 28, 2025
b47b489
Merge branch 'master' into fix/producer-small-futures
ChrisWrenDev Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,15 @@ impl<Exe: Executor> TopicProducer<Exe> {
};

trace!("sending a batched message of size {}", message_count);
let send_receipt = self.send_compress(message).await?.await.map_err(Arc::new);

let compressed_message = self.compress_message(message)?;

let send_receipt = self
.send_inner(compressed_message)
.await?
.await
.map_err(Arc::new);

for resolver in receipts {
let _ = resolver.send(
send_receipt
Expand All @@ -632,7 +640,10 @@ impl<Exe: Executor> TopicProducer<Exe> {
let (tx, rx) = oneshot::channel();
match self.batch.as_ref() {
None => {
let fut = self.send_compress(message).await?;
let compressed_message = self.compress_message(message)?;

let fut = self.send_inner(compressed_message).await?;

self.client
.executor
.spawn(Box::pin(async move {
Expand Down Expand Up @@ -677,7 +688,11 @@ impl<Exe: Executor> TopicProducer<Exe> {
};

trace!("sending a batched message of size {}", counter);
let receipt_fut = self.send_compress(message).await?;

let compressed_message = self.compress_message(message)?;

let receipt_fut = self.send_inner(compressed_message).await?;

self.client
.executor
.spawn(Box::pin(async move {
Expand All @@ -695,10 +710,7 @@ impl<Exe: Executor> TopicProducer<Exe> {
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
async fn send_compress(
&mut self,
mut message: ProducerMessage,
) -> Result<impl Future<Output = Result<CommandSendReceipt, Error>>, Error> {
fn compress_message(&mut self, mut message: ProducerMessage) -> Result<ProducerMessage, Error> {
let compressed_message = match self.compression.clone() {
None | Some(Compression::None) => message,
#[cfg(feature = "lz4")]
Expand Down Expand Up @@ -750,8 +762,7 @@ impl<Exe: Executor> TopicProducer<Exe> {
message
}
};

self.send_inner(compressed_message).await
Ok(compressed_message)
}

#[cfg_attr(feature = "telemetry", tracing::instrument(skip_all))]
Expand Down