Skip to content

Implement SkipDir in powerwalk #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
piotrrojek wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Implement SkipDir in powerwalk #4

piotrrojek wants to merge 7 commits into from

Conversation

@piotrrojek
Copy link

@piotrrojek piotrrojek commented Feb 26, 2016

Simple implementation of SkipDir function.

Addresses #1

@piotrrojek
Copy link
Author

piotrrojek commented Feb 26, 2016

I just realized the issue was related to original Walk from standard library. Oh well...
But maybe it could be useful.

@piotrrojek
Changed Contains to HasPrefix
07644b6 
With that we should avoid edge cases failures.
@piotrrojek
Typo in README
d1b8ab0
@matryer
Copy link
Member

matryer commented Feb 26, 2016

Ah nice. The spec for filepath.Walk asks that the WalkFunc returns an error (filepath.SkipDir) in order to skip the directory. Since walking occurs concurrently, this cannot be done, so I like this approach. Perhaps a SkipDir(path string, info os.FileInfo) bool func would be nice to let the calling code decide this at runtime, rather than having to know up-front?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aviscode aviscode aviscode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piotrrojek @matryer @aviscode