Skip to content

refactor: Modernize samples - #2664

Closed
Kryptos-FR wants to merge 3604 commits into
stride3d:masterfrom
Color-Rise:feature/modernize-samples
Closed

Kryptos-FR wants to merge 3604 commits into
stride3d:masterfrom
Color-Rise:feature/modernize-samples

Conversation

@Kryptos-FR

@Kryptos-FR Kryptos-FR commented Mar 7, 2025 •

Copy link
Copy Markdown
Member

PR Details

Modernize the samples.

I did not enable the nullable feature since it isn't the case yet in the whole codebase. I also excluded the C# tutorials projects (beside using file scope namespaces) because we might to use a different style for them that is more beginner friendly.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Eideren and others added 30 commits June 10, 2024 22:09
* .NET 6 reference missed

* added central version number from Jkao for better consistancy

* updated comment

* Get version from Environment
…pport, and fix model skinning on platforms using OpenGL ES (ie. Android and iOS) (stride3d#2323)

Co-authored-by: Basewq <Basewq@users.noreply.github.com>
* prevents a null IMemberNode to update

* checking properties before calling update
* feat: Adjust freeimage to all platforms

* Adjust FreeImage methods
…fault animation preview model (stride3d#2291)

* ported https://github.com/assimp/assimp/pull/5494/files

* Cleanup

* Potential fix to investigate further

* Fallback to BaseColor when diffuse is not available

* Automatically set preview model on import for animations

* Use BaseColor as Diffuse if Diffuse is not defined

* Document pivot todo

* Rollback transformations related logic

* More cleanup

* Fix issue when trying to import animation from an fbx without animations

---------

Co-authored-by: Eideren <contact@eideren.com>
…or lightweight, abstract and typesafe processing in idiomatic c# (stride3d#2331)

* feat: FlexibleProcessing as alternative to EntityComponentProcessor for lightweight, abstract and typesafe processing in idiomatic c#

* is ... == false to is not

* Access backing buffer of the list to improve get/set operations

* More tests for edge cases
Co-authored-by: Basewq <Basewq@users.noreply.github.com>
Basewq and others added 19 commits February 15, 2025 22:43
…#2638)

Co-authored-by: Basewq <Basewq@users.noreply.github.com>
…s too small to fit even one character. (stride3d#2598)

Signed-off-by: net2cn <mcopener@gmail.com>
* [Core.Mathematics] Modernize code

* [Core.Mathematics] Add tests to Stride.Tests.Simple

* [Core] Cleanup some code

* [Core.CompilerServices] Cleanup some code

* [Core.CompilerServices] Add tests to Stride.Tests.Simple

* [Core.IO] Modernize code

* [Core.MicroThreading] Modernize code

* [Core.Serialization] Modernize code

* [Core.AssemblyProcessor.Tests] Modernize code

* [Core.CompilerServices.Tests] Modernize code

* [Core.Mathematics.Tests] Modernize code

* [Core.Tests] Modernize code

* [Core.Translation] Modernize code

* [Core.Reflection] Modernize code

* Fixes build of Stride.VisualStudio.sln

* [Core.Yaml.Tests] Modernize code

* [Core.Design] Modernize code

* [Core.Design.Tests] Modernize code

* [Core.Mathematics] More annotations

* Fix build of projects that import code from Core.Design

Especially those targeting .NET Framework
…#2650)

* handle orientation, Add SetPose, and fix center of mass issue with non default rotation
…tride3d#2654)

* [Core.Presentation] Modernize code

* [Core.Design] Make ToEnumerable extension safer

It will not throw a cast exception for a type mismatch, but instead filter out bad items.

* [Core.Quantum] Modernize code

* [Core.Quantum.Tests] Modernize code

* [Core.Presentation.Quantum] Modernize code

* [Core.Presentation.Quantum.Tests] Modernize code
* [Tests] Allow running tests on Linux

* [Core] Run tests on Linux

* [Core.Presentation] Run tests on Linux

* [Core.Assets] Run tests on Linux

* [BuilEngine] Run tests on Linux
…3d#2658)

* [Core.BuildEngine.Common] Modernize code

* [Core.Packages] Modernize code

* [Core.Assets.Yaml] Modernize code

* [Build] Remove obsolete Prefer32Bit

* [Core.Assets] Modernize code

* [Core.Assets.Tests] Modernize code

* [Core.Assets.Quantum] Modernize code

* [Core.Assets.Quantum.Tests] Modernize code

* [xunit.runner.stride] Modernize code

* Code review
@Kryptos-FR Kryptos-FR changed the title Feature/modernize samples refactor: Modernize samples Mar 7, 2025
@Kryptos-FR

Copy link
Copy Markdown
Member Author

We have a problem: the integrated code editor in the GameStudio is old and doesn't understand modern C#. It's thinking all modern lines of code are incorrect.

For example :
image

Therefore, we can't modernize the samples before we update (or get rid of) the code editor.

@IXLLEGACYIXL

IXLLEGACYIXL commented Mar 7, 2025 •

Copy link
Copy Markdown
Collaborator

the code editor uses roslyn of net6 the latest roslynpad would understand it

but updating it isnt as easy..

@xen2
xen2 force-pushed the master branch 2 times, most recently from ab329f3 to 482bd28 Compare April 16, 2026 07:56
@xen2 xen2 closed this Jul 16, 2026
@xen2

xen2 commented Jul 17, 2026

Copy link
Copy Markdown
Member

👋 Apologies for the noise here.

This PR was closed unintentionally by a bad force-push to master on my side, which auto-closed a batch of PRs. GitHub won't let me (or you) reopen it, since the close is pinned to the now-rewritten commit.

I've contacted GitHub Support to try reopening these in bulk, but no guarantees. If this change is still relevant, it's a good opportunity to sync your branch with the latest master and open a fresh PR (your code is intact).

Sorry again for the disruption! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: WIP - re-PR if resuming

Development

Successfully merging this pull request may close these issues.