Skip to content

Conversation

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick thoughts.

@scholzj
Copy link
Member

scholzj commented Aug 22, 2025

The way we setup the certificates seems also important to whether we ever expect to have some better scalability or not I guess.

@tinaselenge
Copy link
Contributor Author

The way we setup the certificates seems also important to whether we ever expect to have some better scalability or not I guess.

With this proposal, the same certificate and key (via referenced secret in the CR) will be volume mounted into each KafkaBridge pod if it is scaled to multiple replicas, which is not different than how TLS authentication is configured for KafkaBridge talking to Kafka. My understanding is that KafkaBridge is not truly scalable in terms of consumers, but I'm not sure what is the expectation at the moment, in terms of improving that and what to consider for the certificate setup.

@tinaselenge tinaselenge marked this pull request as ready for review September 2, 2025 17:43
@tinaselenge
Copy link
Contributor Author

I've marked this as ready for review now :)

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, it looks good to me, just few small things.

Signed-off-by: Gantigmaa Selenge <[email protected]>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot Tina :)

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more nits. Mostly formatting. The only real point for discussion is about the SSL protocols. Looks good otherwise.

Signed-off-by: Gantigmaa Selenge <[email protected]>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM, +1 binding.

@tinaselenge
Copy link
Contributor Author

Thank you so much @scholzj @im-konge!

@ppatierno could you please take another look when you get a chance? Thank you!

@PaulRMellor @katheris could you please also take a look if you have time? Thank you!

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tina.
I made some suggestions as I read though.
I wonder if the proposal would benefit from mentioning requirements for documentation and testing?

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me, I just added some clarification and wording comments

Signed-off-by: Gantigmaa Selenge <[email protected]>
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, Tina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants